Const correctness for SphericalVoxelGrid, some other small additions to the walking algorithm. #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
static.constcorrectness for member variables as well, as their values should not change during the lifetime of the container.num_polar_voxels == num_azimuthal_voxels. This can be added again at a later time if it proves to be a common case and efficient. For now, it just adds clutter. Same thing forinitializeVoxelBoundarySegments.inBoundsAngularandinBoundsAzimuthalwhen an angular/voxel/both are hit. @ak-2485 please verify I'm using these correctly. For example, you set it to only checkinboundsAzimuthaleven when it was both a Polar and an Azimuthal hit. So I may be missing something here.How Has This Been Tested?
None required. Semantics should remain the same.
Checklist: